Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: define OPENSSLDIR and ENGINESDIR explicitly #29455

Closed
wants to merge 1 commit into from
Closed

deps: define OPENSSLDIR and ENGINESDIR explicitly #29455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: define OPENSSLDIR and ENGINESDIR explicitly 
According to CVE-2019-1552(*), it is encouraged to change OPENSSLDIR
from the default of /usr/local/ssl to a privileged directory on
Windows. "C:\Program Files\Common Files\SSL" is set as it is the
default path in OpenSSL-1.1.1.

(*) https://www.openssl.org/news/secadv/20190730.txt

Fixes: #29445
  • Loading branch information
@shigeki
shigeki committed Sep 5, 2019
commit d768b62897b9cec4de608af4ee5e2af370d8eb0a
2 changes: 2 additions & 0 deletions deps/openssl/openssl.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,6 +1274,8 @@
'MK1MF_BUILD',
'WIN32_LEAN_AND_MEAN',
'OPENSSL_SYSNAME_WIN32',
'ENGINESDIR="C:\\\Program\ Files\\\Common\ Files\\\SSL"',
'OPENSSLDIR="C:\\\Program\ Files\\\Common\ Files\\\SSL"',
],
'openssl_default_libraries_win': [
'-lgdi32.lib',
Expand Down