Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: more stringent blank-line linting for markdown files #29447

Merged
merged 0 commits into from
Sep 7, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 5, 2019

Update reamrk-preset-lint-node to 1.9.0, which adds linting for
multiple consecutive blank lines.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 5, 2019
@Trott
Copy link
Member Author

Trott commented Sep 5, 2019

@richardlau
Copy link
Member

remark-preset-lint-node is misspelled in the commit message.

@Trott
Copy link
Member Author

Trott commented Sep 5, 2019

Fixed the typo in the commit message, so new Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3881/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 5, 2019
@Trott Trott mentioned this pull request Sep 5, 2019
4 tasks
Trott added a commit that referenced this pull request Sep 7, 2019
PR-URL: #29447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 7, 2019

Landed in ef9ecfb...1e01f3f

@Trott Trott closed this Sep 7, 2019
@Trott Trott merged commit 1e01f3f into nodejs:master Sep 7, 2019
targos pushed a commit that referenced this pull request Sep 20, 2019
PR-URL: #29447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Sep 20, 2019
Update remark-preset-lint-node to 1.9.0, which adds linting for
multiple consecutive blank lines.

PR-URL: #29447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
targos pushed a commit that referenced this pull request Jan 8, 2020
Update remark-preset-lint-node to 1.9.0, which adds linting for
multiple consecutive blank lines.

PR-URL: #29447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
Update remark-preset-lint-node to 1.9.0, which adds linting for
multiple consecutive blank lines.

PR-URL: #29447
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
@Trott Trott deleted the update-rpln-1.9.0 branch January 13, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants