Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix nits regarding stream utilities #28385

Closed
wants to merge 1 commit into from
Closed

doc: fix nits regarding stream utilities #28385

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Unify headings.
  • Conform method mentions with the style guide.
  • Fix links.

### Readable.from() -> ### stream.Readable.from() heading change seems suboptimal and non-typical, but it seems it would be wrong to place this part with descriptions of Readable instances or to leave it as is along with other stream.* utilities, in incorrect structure and sorting place.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 22, 2019
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 24, 2019
@Trott
Copy link
Member

Trott commented Jun 24, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3709/

@addaleax
Copy link
Member

Landed in daa512b

@addaleax addaleax closed this Jun 25, 2019
addaleax pushed a commit that referenced this pull request Jun 25, 2019
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@vsemozhetbyt vsemozhetbyt deleted the doc-stream-util-nits branch June 25, 2019 16:44
targos pushed a commit that referenced this pull request Jul 2, 2019
* Unify headings.
* Conform method mentions with the style guide.
* Fix links.

PR-URL: #28385
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants