Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: do not use fixed port in async-hooks/test-httparser-reuse #28312

Closed
wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Otherwise this was failing on machines which already had a service
running on port 3000.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Otherwise this was failing on machines which already had a service
running on port 3000.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jun 20, 2019
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 21, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau mentioned this pull request Jun 28, 2019
3 tasks
@Trott
Copy link
Member

Trott commented Jun 28, 2019

Landed in bf7edaa

@Trott Trott closed this Jun 28, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 28, 2019
Otherwise this was failing on machines which already had a service
running on port 3000.

PR-URL: nodejs#28312
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@addaleax addaleax deleted the httparser-reuse-3000 branch June 28, 2019 10:51
targos pushed a commit that referenced this pull request Jul 2, 2019
Otherwise this was failing on machines which already had a service
running on port 3000.

PR-URL: #28312
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Jul 2, 2019
Otherwise this was failing on machines which already had a service
running on port 3000.

PR-URL: #28312
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants