Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update markdown linter for Windows line endings #27756

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 17, 2019

Update the markdown linter to work with Windows line endings.
Previously, Windows line endings would break the trailing-spaces plugin.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Update the markdown linter to work with Windows line endings.
Previously, Windows line endings would break the trailing-spaces plugin.
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 17, 2019
@Trott Trott requested a review from bzoz May 17, 2019 22:42
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2019
@Trott
Copy link
Member Author

Trott commented May 20, 2019

Landed in cc7e15f

@Trott Trott closed this May 20, 2019
Trott added a commit to Trott/io.js that referenced this pull request May 20, 2019
Update the markdown linter to work with Windows line endings.
Previously, Windows line endings would break the trailing-spaces plugin.

PR-URL: nodejs#27756
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
targos pushed a commit that referenced this pull request May 20, 2019
Update the markdown linter to work with Windows line endings.
Previously, Windows line endings would break the trailing-spaces plugin.

PR-URL: #27756
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
@BridgeAR BridgeAR mentioned this pull request May 21, 2019
4 tasks
@Trott Trott deleted the windows-trailing-spaces branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants