Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: V8 gyp files fixes #27148

Closed
wants to merge 6 commits into from
Closed

build: V8 gyp files fixes #27148

wants to merge 6 commits into from

Conversation

refack
Copy link
Contributor

@refack refack commented Apr 9, 2019

/CC @nodejs/build-files @nodejs/platform-windows @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform. labels Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@refack refack removed the install Issues and PRs related to the installers. label Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@refack refack self-assigned this Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@refack refack added the review wanted PRs that need reviews. label Apr 9, 2019
@nodejs-github-bot
Copy link
Collaborator

@refack
Copy link
Contributor Author

refack commented Apr 12, 2019

@nodejs/v8-update @nodejs/platform-windows @nodejs/build-files

This enables building with MSVS2019 (Currently blocked by a bug), and also improves build time by optimizing PCH usage, and better integration with clcache.

@nodejs-github-bot
Copy link
Collaborator

@jasnell
Copy link
Member

jasnell commented Jun 19, 2020

There's been no activity on this in over a year and there are conflicts. Closing. Can reopen if someone decides they want to pick it back up.

@jasnell jasnell closed this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. review wanted PRs that need reviews. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants