Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedding: refactor NewIsolate() #26525

Closed
wants to merge 6 commits into from
Closed

embedding: refactor NewIsolate() #26525

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a24ee1
embedding: refactor public `ArrayBufferAllocator` API
addaleax Mar 8, 2019
8a0ff6c
embedding: make `NewIsolate()` API more flexible
addaleax Mar 8, 2019
ff05c1a
fixup! embedding: refactor public `ArrayBufferAllocator` API
addaleax Mar 8, 2019
0f26254
fixup! embedding: make `NewIsolate()` API more flexible
addaleax Mar 8, 2019
45e1f65
fixup! embedding: make `NewIsolate()` API more flexible
addaleax Mar 9, 2019
30d1e83
fixup! embedding: refactor public `ArrayBufferAllocator` API
addaleax Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! embedding: make NewIsolate() API more flexible
  • Loading branch information
@addaleax
addaleax committed Mar 8, 2019
commit 0f26254b416227de5b576a76eebfc0290d3979db
1 change: 1 addition & 0 deletions src/api/environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ void SetIsolateUpForNode(v8::Isolate* isolate) {
isolate->SetMicrotasksPolicy(MicrotasksPolicy::kExplicit);
isolate->SetFatalErrorHandler(OnFatalError);
isolate->SetAllowWasmCodeGenerationCallback(AllowWasmCodeGenerationCallback);
isolate->SetPromiseRejectCallback(task_queue::PromiseRejectCallback);
v8::CpuProfiler::UseDetailedSourcePositionsForProfiling(isolate);
}

Expand Down
4 changes: 0 additions & 4 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,10 +258,6 @@ Environment::Environment(IsolateData* isolate_data,
if (options_->no_force_async_hooks_checks) {
async_hooks_.no_force_checks();
}

// TODO(addaleax): the per-isolate state should not be controlled by
// a single Environment.
isolate()->SetPromiseRejectCallback(task_queue::PromiseRejectCallback);
}

CompileFnEntry::CompileFnEntry(Environment* env, uint32_t id)
Expand Down