Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update ESLint to 5.14.1 #26190

Merged
merged 1 commit into from
Feb 20, 2019
Merged

tools: update ESLint to 5.14.1 #26190

merged 1 commit into from
Feb 20, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 18, 2019

Update ESLint to 5.14.1

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 18, 2019
@danbev
Copy link
Contributor

danbev commented Feb 19, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20877/

EDIT(cjihrig): CI was green.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
Update ESLint to 5.14.1

PR-URL: nodejs#26190
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@cjihrig cjihrig merged commit 14c089b into nodejs:master Feb 20, 2019
@cjihrig cjihrig deleted the eslint branch February 20, 2019 17:27
addaleax pushed a commit that referenced this pull request Feb 21, 2019
Update ESLint to 5.14.1

PR-URL: #26190
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Update ESLint to 5.14.1

PR-URL: #26190
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants