Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: consolidate N-API material in Colalborator Guide #26094

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 14, 2019

Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 14, 2019
@Trott
Copy link
Member Author

Trott commented Feb 14, 2019

@nodejs/n-api

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 14, 2019
Trott added a commit to Trott/io.js that referenced this pull request Feb 16, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: nodejs#26094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 16, 2019

Landed in 5bb7764

@Trott Trott closed this Feb 16, 2019
addaleax pushed a commit that referenced this pull request Feb 17, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: #26094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Feb 26, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: #26094
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Bryan English <[email protected]>
@Trott Trott deleted the moar-napi-edits branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants