Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: keep stdio after exit #26017

Closed
wants to merge 1 commit into from
Closed

worker: keep stdio after exit #26017

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 9, 2019 •
edited
Loading

This addresses review comments from #25871.

Refs: #25871

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
worker: keep stdio after exit
ac84d44 
This addresses review comments from
nodejs#25871.

Refs: nodejs#25871
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2554/pipeline

@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Feb 9, 2019
@addaleax addaleax mentioned this pull request Feb 9, 2019
Closed
@addaleax
Copy link
Member Author

addaleax commented Feb 9, 2019

/cc @nodejs/workers @sam-github

CI: https://ci.nodejs.org/job/node-test-pull-request/20692/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2019
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20734/

@addaleax
Copy link
Member Author

Landed in 9e84a26

@addaleax addaleax closed this Feb 12, 2019
@addaleax addaleax deleted the worker-stdio-keep branch February 12, 2019 00:17
addaleax added a commit that referenced this pull request Feb 12, 2019
@addaleax
worker: keep stdio after exit
9e84a26 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax added a commit that referenced this pull request Feb 13, 2019
@addaleax
worker: keep stdio after exit
23868ba 
This addresses review comments from
#25871.

Refs: #25871

PR-URL: #26017
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @nodejs-github-bot @benjamingr @lpinca @cjihrig