Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x backport] tls cleanups #25968

Closed
wants to merge 2 commits into from
Closed

[v11.x backport] tls cleanups #25968

wants to merge 2 commits into from

Commits on Feb 7, 2019

  1. src: refactor SSLError case statement 

    - Don't use both break and return simultaneously.
- Use case:/UNREACHABLE() to enforce that all cases are handled, instead
  of CHECK().

Backport-PR-URL: nodejs#25968
PR-URL: nodejs#25861
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
    @sam-github
    sam-github committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    22f6d4d View commit details
    Browse the repository at this point in the history

  2. tls: in-line comments and other cleanups 

    PR-URL: nodejs#25861
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: nodejs#25968
    @sam-github
    sam-github committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    29f040a View commit details
    Browse the repository at this point in the history