Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: null not valid as a renegotiate callback #25929

Closed

Conversation

sam-github
Copy link
Contributor

@sam-github sam-github commented Feb 4, 2019

Allow undefined as a callback, but do not allow null.

Belatedly respond to #25876 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Allow undefined as a callback, but do not allow null.
@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Feb 4, 2019
@sam-github
Copy link
Contributor Author

@addaleax
Copy link
Member

addaleax commented Feb 6, 2019

Landed in 00d49ad

@addaleax addaleax closed this Feb 6, 2019
addaleax pushed a commit that referenced this pull request Feb 6, 2019
Allow undefined as a callback, but do not allow null.

PR-URL: #25929
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@sam-github sam-github mentioned this pull request Feb 6, 2019
4 tasks
@sam-github sam-github deleted the only-undef-or-fn-for-reneg branch February 6, 2019 23:11
@addaleax
Copy link
Member

addaleax commented Feb 8, 2019

@sam-github If I understood you correctly, this should be labelled dont-land-on-v11.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants