Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make deleted function public in agent.h #25909

Closed
wants to merge 1 commit into from
Closed

src: make deleted function public in agent.h #25909

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 3, 2019 •
edited
Loading

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 3, 2019
bnoordhuis
bnoordhuis approved these changes Feb 3, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but can you explain why in the commit log? This is like your other PR, right?

@gengjiawen
Copy link
Member Author

@bnoordhuis not quite sure which part you mean.I check the commit log, looks like right to me.

@danbev
Copy link
Contributor

danbev commented Feb 6, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20606/

@danbev
Copy link
Contributor

danbev commented Feb 7, 2019

Re-run of failing node-test-commit-arm/

@gengjiawen
Copy link
Member Author

@danbev Do I need to rebase my code ?

@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

@danbev Do I need to rebase my code ?

I don't thinks so, I've re-run the failing build once more and it now passes:
https://ci.nodejs.org/job/node-test-commit-arm/22021/

@danbev
Copy link
Contributor

danbev commented Feb 8, 2019

Landed in 3a02d39.

@danbev danbev closed this Feb 8, 2019
danbev pushed a commit that referenced this pull request Feb 8, 2019
@gengjiawen @danbev
src: make deleted function public in agent.h
3a02d39 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 8, 2019
@gengjiawen @addaleax
src: make deleted function public in agent.h
de9f37d 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25909
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gengjiawen @danbev @bnoordhuis @nodejs-github-bot