Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add PrintLibuvHandleInformation debug helper #25905

Closed
wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 3, 2019

This function is not only helpful for debugging crashes,
but can also be used as an ad-hoc debugging statement.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes (probably)
  • commit message follows commit guidelines

This function is not only helpful for debugging crashes,
but can also be used as an ad-hoc debugging statement.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 3, 2019
src/debug_utils.cc Outdated Show resolved Hide resolved
@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

Yeah, sorry this didn’t compile/pass … actually running vcbuild test when I’m working on Windows is kinda just too much time 😄

CI: https://ci.nodejs.org/job/node-test-pull-request/20557/

@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 5, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 5, 2019

Landed in 46d9573

@addaleax addaleax closed this Feb 5, 2019
@addaleax addaleax deleted the debug-print branch February 5, 2019 20:54
addaleax added a commit that referenced this pull request Feb 5, 2019
This function is not only helpful for debugging crashes,
but can also be used as an ad-hoc debugging statement.

PR-URL: #25905
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this pull request Feb 6, 2019
This function is not only helpful for debugging crashes,
but can also be used as an ad-hoc debugging statement.

PR-URL: #25905
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants