Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report: separate release metadata #25826

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Conversation

richardlau
Copy link
Member

Report release metadata separately from componentVersions.
Test componentVersions and release values in the report.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2019
@richardlau
Copy link
Member Author

richardlau commented Jan 30, 2019

@richardlau richardlau added the report Issues and PRs related to process.report. label Jan 30, 2019
"openssl": "1.1.0j"
},
"release": {
"name": "node"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document other fields for a normal release build?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly, but a normal release build wouldn't be: "nodejsVersion": "v12.0.0-pre",.

Report release metadata separately from `componentVersions`.
Test `componentVersions` and `release` values in the report.

PR-URL: nodejs#25826
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@richardlau
Copy link
Member Author

Landed in d0d84b0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants