Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: fix typo in error message #25782

Merged
merged 1 commit into from
Jan 31, 2019
Merged

report: fix typo in error message #25782

merged 1 commit into from
Jan 31, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 29, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2435/pipeline

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Jan 29, 2019
@addaleax addaleax added report Issues and PRs related to process.report. and removed process Issues and PRs related to the process subsystem. labels Jan 29, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 30, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20426/

@cjihrig
report: fix typo in error message
973c223 
PR-URL: nodejs#25782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig merged commit 973c223 into nodejs:master Jan 31, 2019
@cjihrig cjihrig deleted the typo branch January 31, 2019 18:02
addaleax pushed a commit that referenced this pull request Feb 1, 2019
@cjihrig @addaleax
report: fix typo in error message
f6c8820 
PR-URL: #25782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @jasnell @Trott @addaleax @gengjiawen @richardlau @gireeshpunathil