Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: Add new perf flags in NODE_OPTIONS #25565

Closed
wants to merge 2 commits into from
Closed

src: Add new perf flags in NODE_OPTIONS #25565

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c49ced
src: allow --perf-basic-prof-only-functions in NODE_OPTIONS
tomgco Jan 18, 2019
dd4518a
src: allow --perf-prof-unwinding-info in NODE_OPTIONS
tomgco Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: allow --perf-prof-unwinding-info in NODE_OPTIONS
  • Loading branch information
@tomgco
tomgco committed Jan 25, 2019
commit dd4518ae9595561a70964f3a6f2f1cbd23eab43b
1 change: 1 addition & 0 deletions doc/api/cli.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,6 +729,7 @@ V8 options that are allowed are:
- `--perf-basic-prof`
- `--perf-basic-prof-only-functions`
- `--perf-prof`
- `--perf-prof-unwinding-info`
- `--stack-trace-limit`

### `NODE_PATH=path[:…]`
Expand Down
4 changes: 4 additions & 0 deletions src/node_options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
V8Option{},
kAllowedInEnvironment);
AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
AddOption("--perf-prof-unwinding-info",
"",
V8Option{},
kAllowedInEnvironment);
AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);

#ifdef NODE_REPORT
Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-cli-node-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ if (!common.isWindows) {
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {
// PerfJitLogger is only implemented in Linux.
expect('--perf-prof', 'B\n');
expect('--perf-prof-unwinding-info', 'B\n');
}

if (common.hasCrypto) {
Expand Down