Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc,worker_threads: revise worker_threads.md #25402

Closed
wants to merge 1 commit into from
Closed

doc,worker_threads: revise worker_threads.md #25402

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 8, 2019

Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2190/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 8, 2019
eugeneo
eugeneo reviewed Jan 8, 2019
View reviewed changes
doc/api/worker_threads.md Outdated Show resolved Hide resolved
eugeneo
eugeneo reviewed Jan 9, 2019
View reviewed changes
doc/api/worker_threads.md Outdated Show resolved Hide resolved
@Trott
doc,worker_threads: revise worker_threads.md
3bd05fb 
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.
@Trott
Copy link
Member Author

Trott commented Jan 9, 2019

Rebased, updated based on nits, force-pushed.

@Trott
Copy link
Member Author

Trott commented Jan 9, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2195/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019
@Trott
Copy link
Member Author

Trott commented Jan 11, 2019

Landed in 1415d57

@Trott Trott closed this Jan 11, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2019
@Trott
doc,worker: revise worker_threads.md
1415d57 
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@Trott @addaleax
doc,worker: revise worker_threads.md
1697604 
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: #25402
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott @BridgeAR
doc,worker: revise worker_threads.md
483a8b6 
Rewrite worker_threads introductory material focusing on simpler and
shorter sentences.

PR-URL: nodejs#25402
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
@Trott Trott deleted the revise-worker-threads-doc branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@eugeneo eugeneo eugeneo approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @eugeneo @jasnell @addaleax @lpinca @cjihrig