Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: fix util.inspect with proxied function #25244

Closed
wants to merge 1 commit into from
Closed

util: fix util.inspect with proxied function #25244

wants to merge 1 commit into from

Conversation

starkwang
Copy link
Contributor

@starkwang starkwang commented Dec 28, 2018 •
edited
Loading

Fixes: #25212

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@starkwang build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2083/pipeline

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 28, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Dec 28, 2018 •
edited
Loading

It does not hurt to do this but it will not solve the overall issue with proxies: they are difficult to reason with and even more difficult to write in a way that does not interfere with things.

We trigger multiple traps while inspecting an object and we can not work around all of the issues that might potentially come up.

Another example that would fail is using an empty array instead of the function.

bnoordhuis
bnoordhuis approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with Ruben's comment but this PR is still an improvement over the status quo so why not?

@starkwang
Copy link
Contributor Author

starkwang commented Dec 28, 2018 •
edited
Loading

We trigger multiple traps while inspecting an object and we can not work around all of the issues that might potentially come up.

@BridgeAR Agreed. We can not fix all these issues. For example, an array with a weird proxy is hard to fix.

But at least we can make it a little better :-)

@starkwang
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19861/

@addaleax
Copy link
Member

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19872/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 30, 2018
@addaleax
Copy link
Member

Landed in 6c7c77e

@addaleax addaleax closed this Dec 31, 2018
addaleax pushed a commit that referenced this pull request Dec 31, 2018
@starkwang @addaleax
util: fix util.inspect with proxied function
6c7c77e 
PR-URL: #25244
Fixes: #25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
targos pushed a commit that referenced this pull request Jan 1, 2019
@starkwang @targos
util: fix util.inspect with proxied function
3797625 
PR-URL: #25244
Fixes: #25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@starkwang @refack
util: fix util.inspect with proxied function
c384144 
PR-URL: nodejs#25244
Fixes: nodejs#25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@starkwang @BethGriggs
util: fix util.inspect with proxied function
64847e3 
PR-URL: #25244
Fixes: #25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@starkwang @BethGriggs
util: fix util.inspect with proxied function
a9b6aea 
PR-URL: #25244
Fixes: #25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@starkwang @MylesBorins
util: fix util.inspect with proxied function
4e2ceba 
PR-URL: #25244
Fixes: #25212
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@cjihrig cjihrig cjihrig approved these changes

@JungMinu JungMinu JungMinu approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird Proxy internal util.inspect error
8 participants
@starkwang @nodejs-github-bot @BridgeAR @addaleax @bnoordhuis @cjihrig @JungMinu @ryzokuken