Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build,tools: update make-v8.sh for ppc64le #24293

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

refack
Copy link
Contributor

@refack refack commented Nov 10, 2018

Follow up to #23839
Fixes: nodejs/build#1536

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 10, 2018
@refack refack self-assigned this Nov 10, 2018
@refack refack added the build Issues and PRs related to build files or the CI. label Nov 10, 2018
@refack
Copy link
Contributor Author

refack commented Nov 10, 2018

ln -s /usr/bin/$CC "$BUILD_TOOLS/gcc"
g++ --version
export PKG_CONFIG_PATH=$BUILD_TOOLS/pkg-config-files
gn gen out.gn/$BUILD_ARCH_TYPE --args='is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="ppc64" target_cpu="ppc64"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me a while to figure out how V8 knows the endianness, since it's not specified on the command line.

I thought it checked compiler defines but no, it's defined in build/config/host_byteorder.gni and it basically assumes LE unless the host arch is one of a select few. ppc64 is not one of the select except when os=AIX.

(And yes, host arch, not target arch. It's not cross-compile ready.)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@refack
Copy link
Contributor Author

refack commented Nov 14, 2018

Lite-CI (since it's only used by test-v8 anyway): https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1615/

PR-URL: nodejs#24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@refack refack removed the request for review from gdams November 16, 2018 20:24
@refack refack merged commit 3d4b281 into nodejs:master Nov 16, 2018
@refack refack deleted the update-tools-make-v8-part2 branch November 16, 2018 20:24
@refack refack removed their assignment Nov 16, 2018
targos pushed a commit that referenced this pull request Nov 18, 2018
PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
codebytere pushed a commit that referenced this pull request Jan 29, 2019
PR-URL: #24293
Fixes: nodejs/build#1536
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI-Change: tweaks to make-v8 test script
5 participants