Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fixed arguments order in process-getactiverequests #24186

Closed
wants to merge 1 commit into from
Closed

test: fixed arguments order in process-getactiverequests #24186

wants to merge 1 commit into from

Conversation

kopylash
Copy link
Contributor

@kopylash kopylash commented Nov 6, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@kopylash
Copy link
Contributor Author

kopylash commented Nov 7, 2018

@trivikr the CI build failed, linter got an error https://travis-ci.com/nodejs/node/jobs/156703762#L459
Can you help with it?

@lpinca
Copy link
Member

lpinca commented Nov 7, 2018

@kopylash commit title is a bit too log. We can use "test: fix args order in process-getactiverequests" to make linter happy.

@kopylash
Copy link
Contributor Author

kopylash commented Nov 7, 2018

I changed commit message, but it's confusing since in guidelines it is written that max length is 72

@gireeshpunathil
Copy link
Member

@trivikr
Copy link
Member

trivikr commented Nov 9, 2018

@kopylash Can you update your branch by following the instructions in Step 9
There was some issue in master, which is now fixed.

@addaleax
Copy link
Member

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 10, 2018
@Trott
Copy link
Member

Trott commented Nov 11, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
PR-URL: nodejs#24186
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member

Trott commented Nov 12, 2018

Landed in 981701b.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 12, 2018
@kopylash kopylash deleted the test-process-fix-arguments-order branch November 12, 2018 08:04
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
PR-URL: #24186
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
PR-URL: nodejs#24186
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this pull request Jan 12, 2019
PR-URL: #24186
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants