Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add async_hooks benchmark test #23556

Closed
wants to merge 2 commits into from
Closed

test: add async_hooks benchmark test #23556

wants to merge 2 commits into from

Conversation

peterjreynoldsii
Copy link
Contributor

Added a minimalist benchmark test for the async-hooks.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@peterjreynoldsii
test: added async-hook benchmark
e63a9cc 
Added a minimalist benchmark test for the async-hooks.
@nodejs-github-bot nodejs-github-bot added the assert Issues and PRs related to the assert subsystem. label Oct 12, 2018
jasnell
jasnell reviewed Oct 12, 2018
View reviewed changes
lib/assert.js Outdated
@@ -82,7 +82,6 @@ const NO_EXCEPTION_SENTINEL = {};

function innerFail(obj) {
if (obj.message instanceof Error) throw obj.message;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unnecessary whitespace change here... we can fix on landing tho

@peterjreynoldsii
test: modified benchmark-async-hooks
dbd354b 
I made some formatting changes to the file I was working on and removed some extra comments.
@targos targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
gabrielschulhof
gabrielschulhof approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@gabrielschulhof gabrielschulhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR changed the title Async hooks benchmark test async_hooks: add benchmark test Oct 12, 2018
@BridgeAR BridgeAR changed the title async_hooks: add benchmark test test: add async_hooks benchmark test Oct 12, 2018
gireeshpunathil
gireeshpunathil approved these changes Oct 13, 2018
View reviewed changes
test/sequential/test-benchmark-async-hooks.js
common.skip('missing crypto');

if (!common.enoughTestMem)
common.skip('Insufficient memory for TLS benchmark test');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/TLS/async-hook ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the landed commit.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@peterjreynoldsii @BridgeAR
test: added async-hook benchmark
d7b0be1 
Added a minimalist benchmark test for the async-hooks.

PR-URL: nodejs#23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@peterjreynoldsii @BridgeAR
test: added async-hook benchmark
7e2edc5 
Added a minimalist benchmark test for the async-hooks.

PR-URL: nodejs#23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR
Copy link
Member

Landed in 7e2edc5 🎉

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@peterjreynoldsii @jasnell
test: added async-hook benchmark
3604d78 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@peterjreynoldsii @addaleax
test: added async-hook benchmark
fa364aa 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@peterjreynoldsii @MylesBorins
test: added async-hook benchmark
abf19da 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@peterjreynoldsii @rvagg
test: added async-hook benchmark
aedf971 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@peterjreynoldsii @MylesBorins
test: added async-hook benchmark
402cb65 
Added a minimalist benchmark test for the async-hooks.

PR-URL: #23556
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@peterjreynoldsii @BridgeAR @jasnell @addaleax @gabrielschulhof @cjihrig @gireeshpunathil @trivikr @targos @nodejs-github-bot