Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: inline common module boolean #23479

Closed
wants to merge 1 commit into from
Closed

test: inline common module boolean #23479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/addons/load-long-path/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';
const common = require('../../common');
if (common.isWOW64)
if (common.isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined))
common.skip('doesn\'t work on WOW64');

const fs = require('fs');
Expand Down
5 changes: 0 additions & 5 deletions test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,6 @@ Platform check for SunOS.

Platform check for Windows.

### isWOW64
* [<boolean>]

Platform check for Windows 32-bit on Windows 64-bit.

### localhostIPv4
* [<string>]

Expand Down
2 changes: 0 additions & 2 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ const isMainThread = (() => {
})();

const isWindows = process.platform === 'win32';
const isWOW64 = isWindows && (process.env.PROCESSOR_ARCHITEW6432 !== undefined);
const isAIX = process.platform === 'aix';
const isLinuxPPCBE = (process.platform === 'linux') &&
(process.arch === 'ppc64') &&
Expand Down Expand Up @@ -725,7 +724,6 @@ module.exports = {
isOSX,
isSunOS,
isWindows,
isWOW64,
localIPv6Hosts,
mustCall,
mustCallAsync,
Expand Down
2 changes: 0 additions & 2 deletions test/common/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import common from './index.js';
const {
isMainThread,
isWindows,
isWOW64,
isAIX,
isLinuxPPCBE,
isSunOS,
Expand Down Expand Up @@ -54,7 +53,6 @@ const {
export {
isMainThread,
isWindows,
isWOW64,
isAIX,
isLinuxPPCBE,
isSunOS,
Expand Down