Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make configure script verbose by default #23408

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 10, 2018

The change that added the --verbose flag was supposed to be
semver-major but already landed in a 10.x release.

Refs: #22450

The change that added the --verbose flag was supposed to be
semver-major but already landed in a 10.x release.

Refs: nodejs#22450
@targos targos requested a review from refack October 10, 2018 13:51
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x labels Oct 10, 2018
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 10, 2018
@targos
Copy link
Member Author

targos commented Oct 10, 2018

Please 👍 to fast-track. I'd like to have this in today's release.

@targos
Copy link
Member Author

targos commented Oct 10, 2018

targos added a commit that referenced this pull request Oct 10, 2018
The change that added the --verbose flag was supposed to be
semver-major but already landed in a 10.x release.

Refs: #22450

PR-URL: #23408
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@targos
Copy link
Member Author

targos commented Oct 10, 2018

Landed in c4aa033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants