Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: improve buffer list inspection #23109

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This makes sure the indentation level is correct, no matter if the
inspected buffer list is inspected on a deeper level and custom
inspect options are now passed through to the actual inspection.
@BridgeAR BridgeAR added the stream Issues and PRs related to the stream subsystem. label Sep 27, 2018
@BridgeAR
Copy link
Member Author

@nodejs/streams PTAL

@BridgeAR
Copy link
Member Author

@nodejs/util PTAL

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/internal/streams/buffer_list.js Show resolved Hide resolved
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2018
@mcollina
Copy link
Member

mcollina commented Sep 28, 2018 via email

@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17546/ ✔️ (besides Windows fanned)

@BridgeAR
Copy link
Member Author

BridgeAR commented Oct 1, 2018

@danbev
Copy link
Contributor

danbev commented Oct 2, 2018

Another rebuild of Windows fanned: https://ci.nodejs.org/job/node-test-commit-windows-fanned/21193/ ✔️

@danbev
Copy link
Contributor

danbev commented Oct 2, 2018

Landed in 9c3c0f4.

@danbev danbev closed this Oct 2, 2018
danbev pushed a commit that referenced this pull request Oct 2, 2018
This makes sure the indentation level is correct, no matter if the
inspected buffer list is inspected on a deeper level and custom
inspect options are now passed through to the actual inspection.

PR-URL: #23109
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig mentioned this pull request Oct 3, 2018
targos pushed a commit that referenced this pull request Oct 3, 2018
This makes sure the indentation level is correct, no matter if the
inspected buffer list is inspected on a deeper level and custom
inspect options are now passed through to the actual inspection.

PR-URL: #23109
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR deleted the buffer-list-inspection branch January 20, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants