Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: remove unnecessary calls to TLS_method() #23077

Closed
wants to merge 1 commit into from
Closed

crypto: remove unnecessary calls to TLS_method() #23077

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 25, 2018

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1007/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Sep 25, 2018
@danbev
Copy link
Contributor Author

danbev commented Sep 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17423/

@danbev
Copy link
Contributor Author

danbev commented Sep 25, 2018

Re-run of failing node-test-commit-windows-fanned.

@danbev
Copy link
Contributor Author

danbev commented Sep 26, 2018

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/17445/

@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/17487/

@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

Rebuild of failing node-test-commit-arm ✔️

@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

Landed in 8316c6f.

@danbev danbev closed this Sep 28, 2018
danbev added a commit that referenced this pull request Sep 28, 2018
@danbev
crypto: remove unnecessary calls to TLS_method()
8316c6f 
PR-URL: #23077
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Sep 28, 2018
@danbev @targos
crypto: remove unnecessary calls to TLS_method()
a493f5e 
PR-URL: #23077
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@danbev @targos
crypto: remove unnecessary calls to TLS_method()
a51d839 
PR-URL: #23077
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@danbev danbev deleted the crypto_tls_methods branch August 20, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danbev @nodejs-github-bot @jasnell @tniessen