[v10.x backport] inspector: workers debugging

.eslintrc.js

@@ -156,8 +156,13 @@ module.exports = {
     ],
     /* eslint-disable max-len */
     // If this list is modified, please copy the change to lib/.eslintrc.yaml
+    // and test/.eslintrc.yaml.
     'no-restricted-syntax': [
       'error',
+      {
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='deepStrictEqual'][arguments.2.type='Literal']",
+        message: 'Do not use a literal for the third argument of assert.deepStrictEqual()'
+      },
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='doesNotThrow']",
         message: 'Please replace `assert.doesNotThrow()` and add a comment next to the code instead.'
@@ -166,6 +171,10 @@ module.exports = {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='rejects'][arguments.length<2]",
         message: 'assert.rejects() must be invoked with at least two arguments.',
       },
+      {
+        selector: "CallExpression[callee.object.name='assert'][callee.property.name='strictEqual'][arguments.2.type='Literal']",
+        message: 'Do not use a literal for the third argument of assert.strictEqual()'
+      },
       {
         selector: "CallExpression[callee.object.name='assert'][callee.property.name='throws'][arguments.1.type='Literal']:not([arguments.1.regex])",
         message: 'Use an object as second argument of assert.throws()',

.mailmap

@@ -131,6 +131,7 @@ Gabriel de Perthuis <[email protected]>
 Gareth Ellis <[email protected]> <[email protected]>
 Garwah Lam <[email protected]>
 Geoffrey Bugaisky <[email protected]> gbugaisky <[email protected]>
+Gerhard Stoebich <[email protected]>
 Gibson Fahnestock <[email protected]> <[email protected]>
 Gil Pedersen <[email protected]> <[email protected]>
 Graham Fairweather <[email protected]> Xotic750 <xotic750@gmail>
@@ -204,6 +205,7 @@ Jérémy Lal <[email protected]> <[email protected]>
 Juan Sebastian Velez Posada <[email protected]>
 Kai Sasaki Lewuathe <[email protected]>
 Karl Skomski <[email protected]> <[email protected]>
+Kat Marchán <[email protected]> <[email protected]>
 Kathy Truong <[email protected]> k3kathy <[email protected]>
 Kazuyuki Yamada <[email protected]>
 Keith M Wesolowski <[email protected]> <[email protected]>
@@ -238,6 +240,7 @@ Matheus Marchini <[email protected]> <[email protected]>
 Matheus Marchini <[email protected]> <[email protected]>
 Matt Lang <[email protected]> matt-in-a-hat <[email protected]>
 Matt Reed <[email protected]> matthewreed26 <[email protected]>
+Matteo Collina <[email protected]> <[email protected]>
 Matthias Bastian <[email protected]> piepmatz <[email protected]>
 Mathias Buus <[email protected]> <[email protected]>
 Mathias Pettersson <[email protected]>
@@ -364,6 +367,7 @@ Tadashi SAWADA <[email protected]>
 Takahiro ANDO <[email protected]>
 Tarun Batra <[email protected]> Tarun <[email protected]>
 Ted Young <[email protected]>
+Teppei Sato <[email protected]>
 Thomas Hunter II <[email protected]> <[email protected]>
 Thomas Lee <[email protected]> <[email protected]>
 Thomas Reggi <[email protected]>
@@ -391,7 +395,8 @@ Vladimir de Turckheim <[email protected]>
 vsemozhetbyt <[email protected]> Vse Mozhet Byt <[email protected]>
 Wang Xinyong <[email protected]> <[email protected]>
 Weijia Wang <[email protected]>
-Weijia Wang <[email protected]> starkewang <[email protected]>
+Weijia Wang <[email protected]> <[email protected]>
+Weijia Wang <[email protected]> <[email protected]>
 Wei-Wei Wu <[email protected]>
 Willi Eggeling <[email protected]>
 Will Hayslett <[email protected]>

AUTHORS

@@ -650,7 +650,7 @@ Micleusanu Nicu <[email protected]>
 Alejandro Oviedo Garcia <[email protected]>
 Ben Burns <[email protected]>
 Julian Duque <[email protected]>
-teppeis <[email protected]>
+Teppei Sato <[email protected]>
 Rudi Cilibrasi <[email protected]>
 Tim Ruffles <[email protected]>
 CGavrila <[email protected]>
@@ -754,14 +754,14 @@ Felipe Batista <[email protected]>
 Rebecca Turner <[email protected]>
 Tyler Anton <[email protected]>
 João Reis <[email protected]>
-Kat Marchán <kzm@sykosomatic.org>
+Kat Marchán <kzm@zkat.tech>
 Ryan Petschek <[email protected]>
 Pierre Inglebert <[email protected]>
 Ivan Yan <[email protected]>
 Sangmin Yoon <[email protected]>
 Mark Plomer <[email protected]>
 Phillip Johnsen <[email protected]>
-Matteo Collina <hello@matteocollina.com>
+Matteo Collina <matteo.collina@gmail.com>
 jomo <[email protected]>
 Gireesh Punathil <[email protected]>
 Lucien Greathouse <[email protected]>
@@ -1432,23 +1432,25 @@ Ahmad Nassri <[email protected]>
 Tom Atkinson <[email protected]>
 Tobias Nießen <[email protected]>
 Joseph Gentle <[email protected]>
+Arunesh Chandra <[email protected]>
+Gabriel Schulhof <[email protected]>
+Ian Halliday <[email protected]>
+Sampson Gao <[email protected]>
+Taylor Woll <[email protected]>
 Zero King <[email protected]>
 Raphael Okon <[email protected]>
 JR McEntee <[email protected]>
 Lovell Fuller <[email protected]>
 Jason Marsh <[email protected]>
 Vinay Hiremath <[email protected]>
-Gabriel Schulhof <[email protected]>
 alejandro <[email protected]>
 dave-k <[email protected]>
 Steven <[email protected]>
 Uppinder Chugh <[email protected]>
 Karl Cheng <[email protected]>
-Taylor Woll <[email protected]>
 Tarun Batra <[email protected]>
 Nao YONASHIRO <[email protected]>
 Christopher Luke <[email protected]>
-Sampson Gao <[email protected]>
 John Paul Bamberg <[email protected]>
 Cody Deckard <[email protected]>
 Fabio Campinho <[email protected]>
@@ -1488,7 +1490,7 @@ Madara Uchiha <[email protected]>
 Gil Tayar <[email protected]>
 Glenn Schlereth <[email protected]>
 Artur G Vieira <[email protected]>
-Flarna <[email protected]>
+Gerhard Stoebich <[email protected]>
 Sreepurna Jasti <[email protected]>
 Rafael Fragoso <[email protected]>
 Andrei Cioromila <[email protected]>
@@ -1658,6 +1660,8 @@ Piotr Mionskowski <[email protected]>
 Cyril Lakech <[email protected]>
 Eduard Bondarenko <[email protected]>
 Adina Shanholtz <[email protected]>
+Guy Bedford <[email protected]>
+Jan Krems <[email protected]>
 Miguel Martins <[email protected]>
 Yury Popov <[email protected]>
 George Bezerra <[email protected]>
@@ -1670,7 +1674,6 @@ Alex Gresnel <[email protected]>
 Will Young <[email protected]>
 Martijn Schrage <[email protected]>
 Halil İbrahim Şener <[email protected]>
-Guy Bedford <[email protected]>
 Antoine Amara <[email protected]>
 Mani Maghsoudlou <[email protected]>
 Bartek Szczepański <[email protected]>
@@ -1884,7 +1887,6 @@ Ashish Kaila <[email protected]>
 c0b <[email protected]>
 Damian <[email protected]>
 Alec Perkins <[email protected]>
-Teppei Sato <[email protected]>
 Jinwoo Lee <[email protected]>
 Peter Marton <[email protected]>
 Erwin W. Ramadhan <[email protected]>
@@ -2154,9 +2156,7 @@ Nick Filatov <[email protected]>
 Jesse Gorzinski <[email protected]>
 Pieter Mees <[email protected]>
 Malcolm White <[email protected]>
-Gerhard Stoebich <[email protected]>
 Matei Copot <[email protected]>
-ikasumiwt <[email protected]>
 Gurin, Sebastian <[email protected]>
 Indranil Dasgupta <[email protected]>
 Harry Sarson <[email protected]>
@@ -2187,7 +2187,6 @@ Kyle Martin <[email protected]>
 Denis Fäcke <[email protected]>
 Daylor Yanes <[email protected]>
 Carrie Coxwell <[email protected]>
-BeniCheni <[email protected]>
 Masashi Hirano <[email protected]>
 Brandon Ruggles <[email protected]>
 Allen Yonghuang Wang <[email protected]>
@@ -2218,6 +2217,7 @@ Abhimanyu Vashisht <[email protected]>
 Sagir Khan <[email protected]>
 Kael Zhang <[email protected]>
 Unknown <[email protected]>
+Krzysztof Taborski <[email protected]>
 Blaine Bublitz <[email protected]>
 Shailesh Shekhawat <[email protected]>
 Davis Okoth <[email protected]>
@@ -2236,5 +2236,86 @@ Shelley Vohr <[email protected]>
 Deepjyoti Mondal <[email protected]>
 Brett Kiefer <[email protected]>
 Kevin Thomas <[email protected]>
+ZaneHannanAU <[email protected]>
+Fernando Doglio <[email protected]>
+Renée Kooi <[email protected]>
+Jo Colina <[email protected]>
+itaysabato <[email protected]>
+Victor Belozyorov <[email protected]>
+Joonas Rouhiainen <[email protected]>
+GauthamBanasandra <[email protected]>
+Hugo Josefson <[email protected]>
+Sam Ruby <[email protected]>
+Haroon Khan <[email protected]>
+Developer Davo <[email protected]>
+Jacek Pospychała <[email protected]>
+MaleDong <[email protected]>
+iwko <[email protected]>
+Sohail Rajdev <[email protected]>
+Niicck <[email protected]>
+Denys Otrishko <[email protected]>
+Sergey Zelenov <[email protected]>
+Travis Fischer <[email protected]>
+Dominic Farolino <[email protected]>
+Octavian Soldea <[email protected]>
+XhmikosR <[email protected]>
+AdityaSrivast <[email protected]>
+Javier Gonzalez <[email protected]>
+RidgeA <[email protected]>
+Ryuichi Sakagami <[email protected]>
+hectorcoronado <[email protected]>
+Petras <[email protected]>
+Kevin Lacabane <[email protected]>
+Simionescu, Radu <[email protected]>
+mariotsi <[email protected]>
+prayag21 <[email protected]>
+Bruno Pinho <[email protected]>
+Anto Aravinth <[email protected]>
+Helio Frota <[email protected]>
+Tim Ruffles <[email protected]>
+Jacob Page <[email protected]>
+sagulati <[email protected]>
+conectado <[email protected]>
+Vitor Bruno de Oliveira Barth <[email protected]>
+cclauss <[email protected]>
+James Ide <[email protected]>
+MaleDong <[email protected]>
+bhavayAnand9 <[email protected]>
+Brandon Lee <[email protected]>
+Oryan Moshe <[email protected]>
+Michael Sommer <[email protected]>
+Eugene Y. Q. Shen <[email protected]>
+Rishabh Singh <[email protected]>
+Marco Levrero <[email protected]>
+Ouyang Yadong <[email protected]>
+yahavfuchs <[email protected]>
+Thomas Leah <[email protected]>
+Musa Hamwala <[email protected]>
+James Bromwell <[email protected]>
+Jeremy Apthorp <[email protected]>
+Eugen Cazacu <[email protected]>
+James Bromwell <[email protected]>
+Csaba Palfi <[email protected]>
+Ryan Petrich <[email protected]>
+Andreas Girgensohn <[email protected]>
+Caleb Sander <[email protected]>
+Dzmitry_Prudnikau <[email protected]>
+Ian McKellar <[email protected]>
+Jennifer Bland <[email protected]>
+Kyle Fuller <[email protected]>
+ZYSzys <[email protected]>
+Neeraj Laad <[email protected]>
+Scott Van Gilder <[email protected]>
+Yaniv Friedensohn <[email protected]>
+Lars-Magnus Skog <[email protected]>
+Lucas Woo <[email protected]>
+Troels Liebe Bentsen <[email protected]>
+pranshuchittora <[email protected]>
+lakamsani <[email protected]>
+Chris White <[email protected]>
+Ben Newman <[email protected]>
+Szymon Marczak <[email protected]>
+Tessei Kameyama <[email protected]>
+Chakravarthy S M <[email protected]>
 
-# Generated by tools/update-authors.sh
+# Generated by tools/update-authors.js

COLLABORATOR_GUIDE.md

@@ -21,6 +21,7 @@
     - [When Breaking Changes Actually Break Things](#when-breaking-changes-actually-break-things)
       - [Reverting commits](#reverting-commits)
   - [Introducing New Modules](#introducing-new-modules)
+  - [Additions to N-API](#additions-to-n-api)
   - [Deprecations](#deprecations)
   - [Involving the TSC](#involving-the-tsc)
 * [Landing Pull Requests](#landing-pull-requests)
@@ -411,6 +412,18 @@ For new modules that involve significant effort, non-trivial additions to
 Node.js or significant new capabilities, an [Enhancement Proposal][] is
 recommended but not required.
 
+### Additions to N-API
+
+N-API provides an ABI stable API that we will have to support in future
+versions without the usual option to modify or remove existing APIs on
+SemVer boundaries. Therefore, additions need to be managed carefully.
+
+This
+[guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md)
+outlines the requirements and principles that we should follow when
+approving and landing new N-API APIs (any additions to `node_api.h` and
+`node_api_types.h`).
+
 ### Deprecations
 
 [_Deprecation_][] is "the discouragement of use of some … feature … or practice,

Makefile

@@ -1087,7 +1087,8 @@ tools/.docmdlintstamp: $(LINT_MD_DOC_FILES)
 LINT_MD_TARGETS = src lib benchmark test tools/doc tools/icu
 LINT_MD_ROOT_DOCS := $(wildcard *.md)
 LINT_MD_MISC_FILES := $(shell find $(LINT_MD_TARGETS) -type f \
-  -not -path '*node_modules*' -name '*.md') $(LINT_MD_ROOT_DOCS)
+  -not -path '*node_modules*' -not -path 'test/fixtures/*' -name '*.md') \
+  $(LINT_MD_ROOT_DOCS)
 run-lint-misc-md = tools/lint-md.js -q -f $(LINT_MD_MISC_FILES)
 # Lint other changed markdown files maintained by us
 tools/.miscmdlintstamp: $(LINT_MD_MISC_FILES)

README.md

@@ -249,6 +249,8 @@ For more information about the governance of the Node.js project, see
 **Franziska Hinkelmann** <[email protected]> (she/her)
 * [Fishrock123](https://github.com/Fishrock123) -
 **Jeremiah Senkpiel** <[email protected]>
+* [gabrielschulhof](https://github.com/gabrielschulhof) -
+**Gabriel Schulhof** <[email protected]>
 * [gibfahn](https://github.com/gibfahn) -
 **Gibson Fahnestock** <[email protected]> (he/him)
 * [jasnell](https://github.com/jasnell) -
@@ -331,6 +333,8 @@ For more information about the governance of the Node.js project, see
 **Benedikt Meurer** <[email protected]>
 * [bnoordhuis](https://github.com/bnoordhuis) -
 **Ben Noordhuis** <[email protected]>
+* [boneskull](https://github.com/boneskull) -
+**Christopher Hiller** <[email protected]> (he/him)
 * [brendanashworth](https://github.com/brendanashworth) -
 **Brendan Ashworth** <[email protected]>
 * [BridgeAR](https://github.com/BridgeAR) -

benchmark/fs/bench-mkdirp.js

@@ -0,0 +1,23 @@
+'use strict';
+
+const common = require('../common');
+const fs = require('fs');
+const tmpdir = require('../../test/common/tmpdir');
+tmpdir.refresh();
+let dirc = 0;
+
+const bench = common.createBenchmark(main, {
+  n: [1e4],
+});
+
+function main({ n }) {
+  bench.start();
+  (function r(cntr) {
+    if (cntr-- <= 0)
+      return bench.end(n);
+    const pathname = `${tmpdir.path}/${++dirc}/${++dirc}/${++dirc}/${++dirc}`;
+    fs.mkdir(pathname, { createParents: true }, (err) => {
+      r(cntr);
+    });
+  }(n));
+}

common.gypi

@@ -29,7 +29,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.25',
+    'v8_embedder_string': '-node.29',
 
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,

deps/v8/include/v8-inspector.h

@@ -214,6 +214,11 @@ class V8_EXPORT V8InspectorClient {
   virtual bool canExecuteScripts(int contextGroupId) { return true; }
 
   virtual void maxAsyncCallStackDepthChanged(int depth) {}
+
+  virtual std::unique_ptr<StringBuffer> resourceNameToUrl(
+      const StringView& resourceName) {
+    return nullptr;
+  }
 };
 
 // These stack trace ids are intended to be passed between debuggers and be

deps/v8/src/field-type.cc

@@ -78,6 +78,7 @@ void FieldType::PrintTo(std::ostream& os) {
     os << "None";
   } else {
     DCHECK(IsClass());
+    HandleScope scope(Map::cast(this)->GetIsolate());
     os << "Class(" << static_cast<void*>(*AsClass()) << ")";
   }
 }

deps/v8/src/inspector/v8-debugger-agent-impl.cc

@@ -1444,7 +1444,7 @@ void V8DebuggerAgentImpl::didParseSource(
         protocol::StringUtil::parseJSON(inspected->auxData()));
   }
   bool isLiveEdit = script->isLiveEdit();
-  bool hasSourceURL = script->hasSourceURL();
+  bool hasSourceURLComment = script->hasSourceURLComment();
   bool isModule = script->isModule();
   String16 scriptId = script->scriptId();
   String16 scriptURL = script->sourceURL();
@@ -1464,7 +1464,8 @@ void V8DebuggerAgentImpl::didParseSource(
   Maybe<protocol::DictionaryValue> executionContextAuxDataParam(
       std::move(executionContextAuxData));
   const bool* isLiveEditParam = isLiveEdit ? &isLiveEdit : nullptr;
-  const bool* hasSourceURLParam = hasSourceURL ? &hasSourceURL : nullptr;
+  const bool* hasSourceURLParam =
+      hasSourceURLComment ? &hasSourceURLComment : nullptr;
   const bool* isModuleParam = isModule ? &isModule : nullptr;
   std::unique_ptr<V8StackTraceImpl> stack =
       V8StackTraceImpl::capture(m_inspector->debugger(), contextGroupId, 1);