Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix a typo in fs.md #22635

Closed
wants to merge 1 commit into from
Closed

doc: fix a typo in fs.md #22635

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

fsPromises.ftruncate() is neither documented nor exported.

cc @jasnell

@vsemozhetbyt
doc: fix a typo in fs.md
1ddae48 
`fsPromises.ftruncate()` is neither documented nor exported.
@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/754/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Aug 31, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 1, 2018
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 2, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in e24fc95
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-fs-typo branch September 2, 2018 15:51
vsemozhetbyt added a commit that referenced this pull request Sep 2, 2018
@vsemozhetbyt
doc: fix a typo in fs.md
e24fc95 
`fsPromises.ftruncate()` is neither documented nor exported.

PR-URL: #22635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Sep 2, 2018
@vsemozhetbyt @targos
doc: fix a typo in fs.md
0fb0e6c 
`fsPromises.ftruncate()` is neither documented nor exported.

PR-URL: #22635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Sep 3, 2018
@vsemozhetbyt @targos
doc: fix a typo in fs.md
395ba7b 
`fsPromises.ftruncate()` is neither documented nor exported.

PR-URL: #22635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@vsemozhetbyt @targos
doc: fix a typo in fs.md
b232606 
`fsPromises.ftruncate()` is neither documented nor exported.

PR-URL: #22635
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vsemozhetbyt @nodejs-github-bot @addaleax @lpinca @targos @cjihrig @gireeshpunathil @BridgeAR @Trott