Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-http-client-timeout-option-with-agent #22403

Closed
wants to merge 3 commits into from
Closed

test: fix flaky test-http-client-timeout-option-with-agent #22403

wants to merge 3 commits into from

Commits on Aug 19, 2018

  1. test: fix flaky http timeout test 

    There is no guarantee that a timeout won't be delayed considerably due
to unrelated activity on the host. Instead of checking that the timeout
happens within a certain tolerance, simply check that it did not happen
too soon.

Fixes: nodejs#22041
    @Trott
    Trott committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    90f3e2f View commit details
    Browse the repository at this point in the history

  2. test: move http timeout test to parallel 

    test-http-client-timeout-option-with-agent no longer checks that the
timeout happens within a certain tolerance so it can be moved to the
parallel test suite.
    @Trott
    Trott committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    0cd6873 View commit details
    Browse the repository at this point in the history

  3. test: improve assert message in http timeout test

    @Trott
    Trott committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    d194aae View commit details
    Browse the repository at this point in the history