Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: see value of "hadError" #22069

Closed
wants to merge 1 commit into from
Closed

test: see value of "hadError" #22069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test/test-tls-hello-parser-failure.js: see value of "hadError" 
The existing implementation created a state that if the assert failed
we got an error message without the values of hadError.
Removed the default error message and added a comment explaining the
assert.
  • Loading branch information
@oryanmoshe
oryanmoshe committed Aug 1, 2018
commit 0f6320b45489385c10ab60cf163551f46dddf908
3 changes: 2 additions & 1 deletion test/parallel/test-tls-hello-parser-failure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ const server = tls.createServer(options, function(c) {
}));

client.on('close', common.mustCall(function(hadError) {
assert.strictEqual(hadError, true, 'Client never errored');
// Confirm that client errored
assert.strictEqual(hadError, true);
}));
}));