Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] src: fix compiler warning in process.ppid #21760

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] src: fix compiler warning in process.ppid #21760

wants to merge 1 commit into from

Conversation

BethGriggs
Copy link
Member

This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: #16958
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Gireesh Punathil [email protected]
Reviewed-By: Timothy Gu [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Daniel Bevenius [email protected]
Reviewed-By: Franziska Hinkelmann [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Backport as requested of #16958

@cjihrig @BethGriggs
src: fix compiler warning in process.ppid
8ac3c67 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

PR-URL: nodejs#16958
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/249/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8.x labels Jul 11, 2018
@BethGriggs
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/19715

MylesBorins pushed a commit that referenced this pull request Jul 13, 2018
@cjihrig @MylesBorins
src: fix compiler warning in process.ppid
c7b1976 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

Backport-PR-URL: #21760
PR-URL: #16958
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@MylesBorins
Copy link
Contributor

landed in c7b1976

rvagg pushed a commit that referenced this pull request Aug 16, 2018
@cjihrig @rvagg
src: fix compiler warning in process.ppid
6f545d1 
This commit fixes a compiler warning with SetAccessor() by
passing in the context.

Backport-PR-URL: #21760
PR-URL: #16958
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Timothy Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@BethGriggs BethGriggs deleted the backport-16958-to-v8.x branch June 11, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BethGriggs @nodejs-github-bot @MylesBorins @addaleax @cjihrig