Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: avoid global install of dmn for lint update #21744

Closed
wants to merge 1 commit into from
Closed

tools: avoid global install of dmn for lint update #21744

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 11, 2018

When updating ESLint, use npx to run dmn rather than installing dmn
globally.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
tools: avoid global install of dmn for lint update
5ba7526 
When updating ESLint, use npx to run dmn rather than installing dmn
globally.
@Trott Trott added the tools Issues and PRs related to the tools directory. label Jul 11, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/248/pipeline

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 11, 2018
@Trott
Copy link
Member Author

Trott commented Jul 11, 2018

(Lite CI should be sufficient as the shell script is not run or even analyzed in CI.)

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 12, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 13, 2018
@Trott
tools: avoid global install of dmn for lint update
19bc893 
When updating ESLint, use npx to run dmn rather than installing dmn
globally.

PR-URL: nodejs#21744
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jul 13, 2018

Landed in 19bc893

@Trott Trott closed this Jul 13, 2018
targos pushed a commit that referenced this pull request Jul 14, 2018
@Trott @targos
tools: avoid global install of dmn for lint update
c26ba08 
When updating ESLint, use npx to run dmn rather than installing dmn
globally.

PR-URL: #21744
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the npx branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @silverwind @jasnell @lpinca @TimothyGu @targos @cjihrig @BridgeAR