Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update changelog with 9.x EOL #21612

Merged
merged 1 commit into from
Jul 10, 2018
Merged

doc: update changelog with 9.x EOL #21612

merged 1 commit into from
Jul 10, 2018

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Jun 30, 2018

This removes unsupported versions from the table, as those might confuse people,
especially given the

Release versions displayed in bold text represent the most
recent actively supported release.

remark below.

It was inconsistent to keep some of the EOL entries in the table while
removing others (v5.x, v7.x) -- this commit takes care of that.

Instead, release status is hinted in the branch list above, highlighting
two main branches -- Current and Active LTS.

Also update the link to the Release repo.

Refs: nodejs/Release#351

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Jun 30, 2018
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 30, 2018
@ChALkeR
Copy link
Member Author

ChALkeR commented Jun 30, 2018

Alternatively, we could remove the LTS/Current/EOL labels from the changelog whatsoever, but to my estimation those rarely need updating, but can have value for users determining which version should they use.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7 maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 10, 2018
This removes unsupported versions from the table, as those might confuse
people, execially given the
  > Release versions displayed in **bold** text represent the most
  > recent actively supported release.
remark below.

It was inconsistent to keep some of the EOL entries in the table while
removing others (v5.x, v7.x) -- this commit takes care of that.

Instead, release status is hinted in the branch list above, highlighting
two main branches -- Current and Active LTS.

Also update the link to the Release repo.

Refs: nodejs/Release#351
PR-URL: nodejs#21612
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@ChALkeR
Copy link
Member Author

ChALkeR commented Jul 10, 2018

Landed in 195480a.

@ChALkeR ChALkeR merged commit 195480a into nodejs:master Jul 10, 2018
targos pushed a commit that referenced this pull request Jul 12, 2018
This removes unsupported versions from the table, as those might confuse
people, execially given the
  > Release versions displayed in **bold** text represent the most
  > recent actively supported release.
remark below.

It was inconsistent to keep some of the EOL entries in the table while
removing others (v5.x, v7.x) -- this commit takes care of that.

Instead, release status is hinted in the branch list above, highlighting
two main branches -- Current and Active LTS.

Also update the link to the Release repo.

Refs: nodejs/Release#351
PR-URL: #21612
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
@targos targos mentioned this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants