Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove outdated comment #21511

Closed
wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

Fixes: #21488

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@TimothyGu TimothyGu added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 24, 2018
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jun 24, 2018
@TimothyGu
Copy link
Member Author

Please 👍 for fast-tracking.

CI: https://ci.nodejs.org/job/node-test-pull-request/15585/

TimothyGu added a commit to TimothyGu/node that referenced this pull request Jun 24, 2018
PR-URL: nodejs#21511
Fixes: nodejs#21488
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@TimothyGu
Copy link
Member Author

Landed in 6396574.

@TimothyGu TimothyGu closed this Jun 24, 2018
@TimothyGu TimothyGu deleted the remove-crypto-comment branch June 24, 2018 22:03
targos pushed a commit that referenced this pull request Jun 25, 2018
PR-URL: #21511
Fixes: #21488
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@targos targos mentioned this pull request Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menacing thread safety comment in node_crypto.cc
4 participants