Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-dns error message #21116

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 3, 2018

test-dns is in the internet suite and therefore is rarely run. (That
will change soon. We will run internet tests nightly in CI.) Because it
is infrequently run, it was not noticed that it no longer passes. (An
error message has changed to provide more information.) This change
fixes the test so it passes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test-dns is in the internet suite and therefore is rarely run. (That
will change soon. We will run internet tests nightly in CI.) Because it
is infrequently run, it was not noticed that it no longer passes. (An
error message has changed to provide more information.) This change
fixes the test so it passes.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 3, 2018
@Trott
Copy link
Member Author

Trott commented Jun 3, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/803/

(Used Lite Ci because internet tests are not run in regular CI, so we're really just linting.)

Custom Suites CI (which runs internet tests): https://ci.nodejs.org/job/node-test-commit-custom-suites/7/

The Custom Suites CI has two other tests failing (dgram tests) that need to be reviewed. Their failures should be ignored for this PR.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 3, 2018
@Trott
Copy link
Member Author

Trott commented Jun 3, 2018

👍 here for fast-tracking

@addaleax
Copy link
Member

addaleax commented Jun 3, 2018

Landed in 60eeba4

@addaleax addaleax closed this Jun 3, 2018
addaleax pushed a commit that referenced this pull request Jun 3, 2018
test-dns is in the internet suite and therefore is rarely run. (That
will change soon. We will run internet tests nightly in CI.) Because it
is infrequently run, it was not noticed that it no longer passes. (An
error message has changed to provide more information.) This change
fixes the test so it passes.

PR-URL: #21116
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
test-dns is in the internet suite and therefore is rarely run. (That
will change soon. We will run internet tests nightly in CI.) Because it
is infrequently run, it was not noticed that it no longer passes. (An
error message has changed to provide more information.) This change
fixes the test so it passes.

PR-URL: #21116
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
@Trott Trott deleted the dns-test branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants