https: defines maxHeadersCount in the constructor #20359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@nodejs/http @nodejs/http2 PTAL |
mcollina
reviewed
Apr 30, 2018
|
|
||
| process.on('exit', () => { | ||
| assert.strictEqual(requests, maxAndExpected.length); | ||
| assert.strictEqual(responses, maxAndExpected.length); |
There was a problem hiding this comment.
This should not be needed if you use common.mustCall().
| let max = maxAndExpected[requests][0]; | ||
| let expected = maxAndExpected[requests][1]; | ||
|
|
||
| const server = https.createServer(serverOptions, (req, res) => { |
There was a problem hiding this comment.
the callback should be wrapped in common.mustCall().
| ]; | ||
| doRequest(); | ||
|
|
||
| function doRequest() { |
There was a problem hiding this comment.
this function should be wrapped in common.mustCall(), with the total number of time it needs to be called.
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on. Also in https.Server, we can use maxHeadersCount the same as http via connectionListener. So, defines it in the constructor and documentation. Refs: nodejs#9116
darai0512
force-pushed
the
init-https-prop
branch
from
990a69a
to
cee0ad3
Compare
|
@mcollina Thanks for your reviews. PTAL |
trivikr
pushed a commit
that referenced
this pull request
May 3, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
mcollina
added
the
author ready
trivikr
approved these changes
May 3, 2018
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 6779096 |
addaleax
pushed a commit
that referenced
this pull request
May 5, 2018
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on. Also in https.Server, we can use maxHeadersCount the same as http via connectionListener. So, defines it in the constructor and documentation. Refs: #9116 PR-URL: #20359 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on. Also in https.Server, we can use maxHeadersCount the same as http via connectionListener. So, defines it in the constructor and documentation. Refs: #9116 PR-URL: #20359 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
In http.ClientRequest's doc, add maxHeadersCount as a public property. And in the description of server's one, change a hyphen to a comma. PR-URL: #20361 Refs: #20359 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on. Also in https.Server, we can use maxHeadersCount the same as http via connectionListener. So, defines it in the constructor and documentation. Refs: #9116 PR-URL: #20359 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on. Also in https.Server, we can use maxHeadersCount the same as http via connectionListener. So, defines it in the constructor and documentation. Refs: #9116 PR-URL: #20359 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Refs, http.Server's maxHeadersCount field was defined in the constructor to make hidden class stable and so on.
Also in https.Server, we can use maxHeadersCount the same as http via connectionListener.
So defines it in the constructor and documentation.
Refs: #9116
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes