test: added coverage for fs/promises API #20219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
reviewed
Apr 23, 2018
| validateWrite() | ||
| .then(validateEmptyWrite) | ||
| .then(validateNonUint8ArrayWrite) | ||
| .then(common.mustCall()); |
There was a problem hiding this comment.
It would be great to run those validations in parallel instead of waiting on the result of the former ones. Therefore it would be good to write this as:
Promise.all([
validateWrite(),
validateEmptyWrite(),
validateNonUint8ArrayWrite()
]).then(common.mustCall());To make sure that works as expected, the temp files have to be unique though (have a unique name).
There was a problem hiding this comment.
@BridgeAR : Thanks for the feedback. As you said, makes sense to run those validations in parallel. I've updated the PR with the changes. Kindly review. Thanks.
jasnell
approved these changes
Apr 23, 2018
BridgeAR
approved these changes
Apr 23, 2018
This comment has been minimized.
This comment has been minimized.
BridgeAR
added
fast-track
trivikr
approved these changes
Apr 24, 2018
TimothyGu
approved these changes
Apr 24, 2018
|
Landed in 062a6e2 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Apr 26, 2018
PR-URL: nodejs#20219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20219 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added coverage for block inside
promises#writewhere thebufferfailsisUint8ArraycheckChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes