Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: move trevnorris to TSC Emeritus #19985

Closed
wants to merge 1 commit into from
Closed

doc: move trevnorris to TSC Emeritus #19985

wants to merge 1 commit into from

Conversation

trevnorris
Copy link
Contributor

I'll still be around, but won't be able to contribute enough to merit
TSC status.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 12, 2018
cjihrig
cjihrig approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for everything Trevor!

BridgeAR
BridgeAR reviewed Apr 12, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all you did for Node.js!

README.md Outdated
@@ -504,8 +506,6 @@ For more information about the governance of the Node.js project, see
**Tiancheng "Timothy" Gu** <[email protected]> (he/him)
* [tniessen](https://github.com/tniessen) -
**Tobias Nießen** <[email protected]>
* [trevnorris](https://github.com/trevnorris) -
**Trevor Norris** <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong spot to be removed from.

Trott
Trott approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to see you go. Glad you'll still be around! Thanks for everything!

Trott
Trott requested changes Apr 12, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, Ruben correctly points out that the removal is from the wrong list....

Trott
Trott reviewed Apr 12, 2018
View reviewed changes
README.md Outdated
@@ -283,6 +283,8 @@ For more information about the governance of the Node.js project, see
**Isaac Z. Schlueter** <[email protected]>
* [joshgav](https://github.com/joshgav) -
**Josh Gavant** <[email protected]>
* [trevnorris](https://github.com/trevnorris) -
**Trevor Norris** <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm...also added in the wrong place. (Lists are all alphabetical by GitHub handle.) I'll fix both of these things in a moment, assuming I have push access on the branch...

@trevnorris @Trott
doc: move trevnorris to TSC Emeritus
5341b83 
I'll still be around, but won't be able to contribute enough to merit
TSC status.
Trott
Trott approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all fixed up.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 12, 2018
@Trott
Copy link
Member

Trott commented Apr 12, 2018 •
edited
Loading

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/507/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 12, 2018
@Trott
Copy link
Member

Trott commented Apr 12, 2018

Re-running lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/508/

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 12, 2018
@trevnorris @Trott
doc: move trevnorris to TSC Emeritus
636bac7 
I'll still be around, but won't be able to contribute enough to merit
TSC status.

PR-URL: nodejs#19985
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@Trott
Copy link
Member

Trott commented Apr 12, 2018

Landed in 636bac7

@Trott Trott closed this Apr 12, 2018
@mcollina
Copy link
Member

Thanks again @trevnorris!

@MylesBorins
Copy link
Contributor

Thanks for all the hard work!

jasnell pushed a commit that referenced this pull request Apr 16, 2018
@trevnorris @jasnell
doc: move trevnorris to TSC Emeritus
4d7bbe8 
I'll still be around, but won't be able to contribute enough to merit
TSC status.

PR-URL: #19985
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@trevnorris @BridgeAR
doc: move trevnorris to TSC Emeritus
5234b34 
I'll still be around, but won't be able to contribute enough to merit
TSC status.

PR-URL: nodejs#19985
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@trevnorris trevnorris deleted the trevnorris-emeritus branch October 27, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.