Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve CCM example #19851

Closed
wants to merge 1 commit into from
Closed

doc: improve CCM example #19851

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 6, 2018

The nonce must be transmitted along with ciphertext and tag.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@tniessen
doc: improve CCM example
86ef4bc 
The nonce must be transmitted along with ciphertext and tag.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Apr 8, 2018

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite/451/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 8, 2018
@tniessen tniessen removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 9, 2018
@tniessen
Copy link
Member Author

tniessen commented Apr 9, 2018

Landed in 99c77dc.

@tniessen tniessen closed this Apr 9, 2018
tniessen added a commit that referenced this pull request Apr 9, 2018
@tniessen
doc: improve CCM example
99c77dc 
The nonce must be transmitted along with ciphertext and tag.

PR-URL: #19851
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos added dont-land-on-v9.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @BridgeAR @jasnell @Trott @targos @nodejs-github-bot