Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-http-client-timeout-agent to sequential #19809

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 4, 2018

Move resource-sensitive test from parallel to sequential.

Fixes: #19804

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Move resource-sensitive test from parallel to sequential.

Fixes: nodejs#19804
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 4, 2018
@Trott
Copy link
Member Author

Trott commented Apr 5, 2018

@Trott
Copy link
Member Author

Trott commented Apr 5, 2018

Lone CI failure is unrelated. FreeBSD re-run: https://ci.nodejs.org/job/node-test-commit-freebsd/16732/

@lpinca
Copy link
Member

lpinca commented Apr 5, 2018

I'd use "test: move test-http-client-timeout-agent" as commit title.

@Trott Trott changed the title test: fix flaky test-http-client-timeout-agent test: move test-http-client-timeout-agent to sequential Apr 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Apr 7, 2018
Move resource-sensitive test from parallel to sequential.

Fixes: nodejs#19804

PR-URL: nodejs#19809
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Apr 7, 2018

Landed in 95dc590

@Trott Trott closed this Apr 7, 2018
targos pushed a commit that referenced this pull request Apr 12, 2018
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
Move resource-sensitive test from parallel to sequential.

Fixes: nodejs#19804

PR-URL: nodejs#19809
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 1, 2018
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
Move resource-sensitive test from parallel to sequential.

Fixes: #19804

PR-URL: #19809
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
@Trott Trott deleted the flaky-crust branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

investigate flaky parallel/test-http-client-timeout-agent
6 participants