Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: do not use EOL in ERR_ASSERTION messages #19221

Closed
wants to merge 1 commit into from
Closed

assert: do not use EOL in ERR_ASSERTION messages #19221

wants to merge 1 commit into from

Commits on Mar 7, 2018

  1. assert: do not use EOL in ERR_ASSERTION messages 

    On Windows if an error is thrown from a script that uses `\n`
to break lines - which is very common in the JavaScript ecosystem,
and is the case in our own code base -
then the error messages would contain mixed line feeds:
the part coming from the source code breaks with `\n` while the
message itself break with `\r\n`.

Since we do not use `\r\n` in util.inspect(), we should use `\n`
in error messages as well.
    @joyeecheung
    joyeecheung committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    25a18af View commit details
    Browse the repository at this point in the history