Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: rename regression tests with descriptive file names #19161

Closed
wants to merge 8 commits into from
Closed

test: rename regression tests with descriptive file names #19161

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
51e7956
test: rename test-regress-GH-1726
ryzokuken Mar 6, 2018
713a7d5
test: rename test-regress-GH-1697
ryzokuken Mar 6, 2018
e699b92
test: rename test-regress-GH-4015
ryzokuken Mar 6, 2018
7b91ada
test: rename test-regress-GH-4027
ryzokuken Mar 6, 2018
24016c4
test: rename tests to remove "regress" keyword
ryzokuken Mar 6, 2018
5b96920
test: address nits and rename the corresponding fixture
ryzokuken Mar 6, 2018
8532aaa
test: rename test-regress-GH-784.js
ryzokuken Mar 6, 2018
c3cc56b
test: rename test-regress-GH-877.js
ryzokuken Mar 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: address nits and rename the corresponding fixture 
Refs: #19105
  • Loading branch information
@ryzokuken
ryzokuken committed Mar 6, 2018
commit 5b96920800cd5e3841fd74444ac3a2771791b3fe
0 test/fixtures/test-regress-GH-4015.js → test/fixtures/test-fs-stat-sync-overflow.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion test/sequential/test-fs-stat-sync-overflow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const assert = require('assert');
const { exec } = require('child_process');

const cmd =
`"${process.execPath}" "${fixturesDir}/test-regress-GH-4015.js"`;
`"${process.execPath}" "${fixturesDir}/test-fs-stat-sync-overflow.js"`;

exec(cmd, function(err, stdout, stderr) {
assert(/RangeError: Maximum call stack size exceeded/.test(stderr));
Expand Down
2 changes: 1 addition & 1 deletion test/sequential/test-net-response-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
const common = require('../common');

// Make sure the net module's server doesn't throw an error when handling
// responses that are either too long or too small (especially on windows)
// responses that are either too long or too small (especially on Windows)
// https://github.com/nodejs/node-v0.x-archive/issues/1697

const net = require('net');
Expand Down