Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable openssl build warnings on macos #19046

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

We already disable -Wmissing-field-initializers on other Unices but
not on MacOS.

Fixes: #18983 (partially)

We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

Fixes: nodejs#18983 (partially)
@nodejs-github-bot nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Feb 27, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 1, 2018
@apapirovski
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13480/ (will land once OS X compiles)

@apapirovski
Copy link
Member

Landed in cb94bf0

@apapirovski apapirovski closed this Mar 4, 2018
apapirovski pushed a commit that referenced this pull request Mar 4, 2018
We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

PR-URL: #19046
Fixes: #18983
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

PR-URL: nodejs#19046
Fixes: nodejs#18983
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

PR-URL: nodejs#19046
Fixes: nodejs#18983
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
We already disable `-Wmissing-field-initializers` on other Unices but
not on MacOS.

PR-URL: #19046
Fixes: #18983
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants