Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: unify type linkification #18407

Closed
wants to merge 2 commits into from
Closed

doc: unify type linkification #18407

wants to merge 2 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Jan 27, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, tools

Two types in http2.md were out of tune with the main method of custom type linkification — via type/URL map in tools/doc/type-parser.js. So I've tried to unify them. I've added an 'HTTP2' prefix so they can be more clear in tools/doc/type-parser.js, out of the narrow unambiguous context. I've also preserved this prefix in common links inside the http2.md to save the association.

These 2 new types are the only types with spaces, but this should be OK for tools/doc/type-parser.js parsing method.

P.S. Also add one missing type in the second commit (ServerHttp2Stream).

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 27, 2018
@vsemozhetbyt
Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt added the http2 Issues or PRs related to the http2 subsystem. label Jan 27, 2018
@vsemozhetbyt
Copy link
Contributor Author

Sorry, add one missing type in the second commit.

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/131/

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 27, 2018
vsemozhetbyt added a commit that referenced this pull request Jan 28, 2018
PR-URL: #18407
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 5c8ce90

@vsemozhetbyt vsemozhetbyt deleted the doc-unify-type-linking branch January 28, 2018 01:51
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
PR-URL: #18407
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
vsemozhetbyt added a commit that referenced this pull request Feb 6, 2018
PR-URL: #18601
Refs: #18407
Refs: #18444
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
PR-URL: nodejs#18407
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
Backport-PR-URL: #20456
PR-URL: #18407
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18407
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18601
Refs: nodejs#18407
Refs: nodejs#18444
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants