Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove non-style information from style guide #17866

Closed
wants to merge 4 commits into from
Closed

doc: remove non-style information from style guide #17866

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23fd08e
doc: remove non-style information from style guide
Trott Dec 25, 2017
295ae9b
squash
Trott Dec 27, 2017
beaafb3
squash: add note to onboarding doc
Trott Dec 30, 2017
02ec302
squash
Trott Dec 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash
  • Loading branch information
@Trott
Trott committed Dec 30, 2017
commit 02ec302e6e6429a17c2c9c8b5d36f7c69c8bd4f2
4 changes: 2 additions & 2 deletions doc/onboarding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ onboarding session.
* Note that they are nits when you comment: `Nit: change foo() to bar().`
* If they are stalling the pull request, fix them yourself on merge.
* Insofar as possible, issues should be identified by tools rather than human
reviewers. If you are leaving comments that could be identified by tools but
are not, consider implementing the necessary tooling.
reviewers. If you are leaving comments about issues that could be identified
by tools but are not, consider implementing the necessary tooling.
* Minimum wait for comments time
* There is a minimum waiting time which we try to respect for non-trivial
changes, so that people who may have important input in such a distributed
Expand Down