Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-benchmark-fs #17853

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-benchmark-fs #17853

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 24, 2017

test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. labels Dec 24, 2017
@Trott
Copy link
Member Author

Trott commented Dec 24, 2017

@Trott
Copy link
Member Author

Trott commented Dec 24, 2017

test-benchmark-fs is passing again on Raspberry Pi. 🎉

@Trott
Copy link
Member Author

Trott commented Dec 25, 2017

Landed in c08f0d1

@Trott Trott closed this Dec 25, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 25, 2017
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: nodejs#17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: #17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: #17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: #17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: #17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
gibfahn pushed a commit that referenced this pull request Jan 24, 2018
test-benchmark-fs uses common.tmpDir without first insuring it exists by
calling common.refreshTmpDir(). Add that function call.

PR-URL: #17853
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott deleted the refresh branch January 13, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants