fs: fix fs.readFile, fs.exists{Sync} regression caused by assertions #17852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
fs
joyeecheung
added
the
semver-major
starkwang
reviewed
Dec 25, 2017
| @@ -340,6 +340,10 @@ fs.accessSync = function(path, mode) { | |||
| fs.exists = function(path, callback) { | |||
| if (handleError((path = getPathFromURL(path)), cb)) | |||
| return; | |||
| if (typeof path !== 'string' && !(path instanceof Buffer)) { | |||
There was a problem hiding this comment.
Should these type checks be placed at the beginning of these methods?
There was a problem hiding this comment.
@starkwang No because the check must happen after getPathFromURL(path) is called. The path may be a string, a Buffer, or a URL-like object.
jasnell
approved these changes
Dec 26, 2017
joyeecheung
added
author ready
|
This is not semver-major itself, it just fixes regressions in #17667 which is semver-major. So added dont land labels instead. |
|
:/ ... ah, right, technically speaking the previous behavior is "throwing old-style type errors", so this is still semver-major. @nodejs/tsc this needs one more TSC approval to land, please review |
joyeecheung
added
semver-major
cjihrig
approved these changes
Dec 27, 2017
apapirovski
pushed a commit
that referenced
this pull request
Dec 27, 2017
PR-URL: #17852 Refs: #17667 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
apapirovski
pushed a commit
that referenced
this pull request
Dec 27, 2017
PR-URL: #17852 Refs: #17667 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs
Refs: #17667
#17667 didn't include the path validation of these methods in JS land, so passing undefined as paths to them would go straight to assertions, which caused CITGM regression https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1165/ . This PR fixes that by adding those validations back.