Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test description to fs.readFile tests #17610

Closed

Conversation

davisjam
Copy link
Contributor

See #17054 here.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 11, 2017
@davisjam davisjam changed the title Add test description to fs.readFile tests test: add test description to fs.readFile tests Dec 11, 2017
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 11, 2017
@maclover7
Copy link
Contributor

@davisjam
Copy link
Contributor Author

I still haven't figured out how to drill through Jenkins to find the console output for the CI failure.

@Trott
Copy link
Member

Trott commented Dec 12, 2017

I still haven't figured out how to drill through Jenkins to find the console output for the CI failure.

@davisjam In this case:

  • go to the bottom center of the CI page and follow the link that says build #14753 (to the right of node-test-commit)
  • scroll to the bottom of the resulting page and find the one that failed (with a white exclamation point inside a red circle), in this case node-test-commit-plinux. Follow the link to the right of it that says build #13879
  • once again, on the resulting page, scroll to the bottom and look at the bottom center to find the host that failed (again, denoted by an exclamation point). In this case, it's ppcle-ubuntu1404. Follow that link.
  • On the resulting page, you now have two options. For a nifty readable interface, select "Console Output" from the list of links on the left side. There's also a plain text option "View as plain text" under that "Console Output" link. In this particular case, it looks like the build failed during the compilation of addons or something like that. No tests were run. Or something weird happened anyway:
make: *** [run-ci] Error 2
Process leaked file descriptors. See https://jenkins.io/redirect/troubleshooting/process-leaked-file-descriptors for more information

@nodejs/build FYI on that build failure (for anyone that wants to investigate mysterious build failures, no need to comment here, although feel free to open an issue in nodejs/build or wherever of course!).

Just in case it really is a problem with this PR (which seems highly unlikely), here's a re-run:
https://ci.nodejs.org/job/node-test-commit-plinux/13885/

@davisjam If the instructions for getting to the console output above don't work for you, let me know what step you got stuck on and I'll try to provide a screenshot or something.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Dec 12, 2017
PR-URL: nodejs#17610
Refs: nodejs#17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Thanks a lot. Landed in dd2200e

@davisjam please note that the commit message was not according to the commit guidlines that are linked in the the PR. I added the subsystem accordingly.

@BridgeAR BridgeAR closed this Dec 12, 2017
@davisjam
Copy link
Contributor Author

@BridgeAR Thank you for fixing that. I'll try to be more careful.

@davisjam
Copy link
Contributor Author

davisjam commented Dec 12, 2017

@Trott Thanks for the guide. I see the failure now. Definitely not my fault :-)

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
MylesBorins pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2017
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
PR-URL: #17610
Refs: #17054 (comment)
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Reviewed-By: Jon Moss <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants