Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use common.crashOnUnhandledRejection #17233

Closed
wants to merge 2 commits into from
Closed

test: use common.crashOnUnhandledRejection #17233

wants to merge 2 commits into from

Conversation

shiningjason
Copy link

@shiningjason shiningjason commented Nov 22, 2017

add common.crashOnUnhandledRejection() to test/parallel/test-repl-load-multiline.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
common.crashOnUnhandledRejection();
Copy link
Contributor

@MylesBorins MylesBorins Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move this to line 7 below all the require statements

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MylesBorins I have moved this to line 7, thanks to review.

@gireeshpunathil
Copy link
Member

@MylesBorins - are these code&learn?

@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdex mscdex added the repl Issues and PRs related to the REPL subsystem. label Nov 22, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @MylesBorins' comment addressed (which can be done on landing fwiw)

@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@MylesBorins
Copy link
Contributor

Landed in 317f596

MylesBorins pushed a commit that referenced this pull request Nov 23, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17233
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants