Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: corrected the spelling of omitting in dgram.md. #16910

Closed
wants to merge 1 commit into from
Closed

doc: corrected the spelling of omitting in dgram.md. #16910

wants to merge 1 commit into from

Conversation

vidyasubramanyam
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations. labels Nov 10, 2017
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11329/

@gireeshpunathil gireeshpunathil mentioned this pull request Nov 11, 2017
Closed
@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

@vidyasubramanyam Thanks so much for your first commit 🎉. Landed as b9a7721

@fhinkel fhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@vidyasubramanyam @fhinkel
doc: correct the spelling of omitting in dgram.md
b9a7721 
PR-URL: #16910
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@vidyasubramanyam @evanlucas
doc: correct the spelling of omitting in dgram.md
3ba52c1 
PR-URL: #16910
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@evanlucas evanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@vidyasubramanyam @MylesBorins
doc: correct the spelling of omitting in dgram.md
0b8a400 
PR-URL: #16910
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@gibfahn gibfahn mentioned this pull request Nov 21, 2017
Merged
This was referenced Mar 9, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@vidyasubramanyam @gireeshpunathil @fhinkel @jasnell @lpinca @cjihrig @tniessen @MylesBorins @nodejs-github-bot